New web ui #2226
New web ui #2226
Conversation
ldez
added
WIP
and removed
status/0-needs-triage
area/provider/docker
area/provider/ecs
labels
|
@jkuri Wow, that's awesome 🎉 Thanks a lot for this 👍
Definitely 😻 !
I suggest to do this in another PR if you don't mind ;) |
|
@emilevauge thanks for that feedback 👍 I will continoue now with live charts and use current implementation of API as you suggested. |
|
I wonder if we have considered if angular is the correct framework to use, if as I understand upgrading to the latest angular will involve rewriting much of the frontend code.
I have no particular preference as to what the best option is, and I am totally willing to be told by anyone who will actually work on this that Angular is indeed still the best tool for the job. I just think it might be wise to at least consciously decide to use Angular or something else if time is going to be spent on reworking this code. Honestly though @jkuri if you are happy with the direction you are taking this in, please feel free to ignore me :) |
|
I am not sure about popularity because I am not following statistics about this, I think its irrelevant. What I can say is that is definitely the fastest and the size of the bundle is relevant to how and in which case you include some parts of the Angular. If you have included all packages that it provides then its definitely not the lightest. Also, I think you said that without a solid foundation of knowledge of web frameworks, don't get me wrong, afterall you can do it in jQuery if you like. I like this project a lot and wanted to help with this thing how I can and where I see that it can be improved. And I got this refactor almost done, in the evening I will push the changes then please check again. Thanks. |
|
@ldez Vue.js is fast and easy to learn, that's what I heard. |
|
Hey @jkuri , first of : Thanks! :) I really like the effort you've put into this. On technical part, I got to agree that vue.js might be a good starter compared in weight and stuff to angular. Knowing to you might be up to help is very good to know. Thanks! :) |
|
no problem at all. for what I have now currently the bundle size (gzipped) is |
|
I think that's not so hardcore and every mobile connection can handle this. |
|
IMHO, the framework we will use is not significant here. Regardless which one we will choose, it will be outdated in the coming months 😄 Besides, I don't think the bundle size is something we should really care about as:
To my mind, the current refactor is really welcomed, even with the latest & less-hyped Angular ;) |
|
I'm with @emilevauge here. One thing we may want to pay attention to at some point is performance: We have one environment with ~300 backends, and the web UI already takes 2-3 secs to load. Scrolling feels a bit sluggish too. I guess that's more a matter of redesigning the UI than choosing a particular framework, however. |
|
Emile and Timo thanks for support there. This is how it looks currently, still status code bar chart and tests missing.
Btw, I made this thing here as @emilevauge suggested; making request every 3 second, so this is a subject that is going to change in the future prs. |
|
@jkuri don't forget the dashboard filter 😉 |
|
@jkuri any news? |
|
@ldez I'll try to finish it today. Sorry but been real busy lately. |
jkuri
force-pushed
the
ui
branch
2 times, most recently
from
3ef53c4
to
ee256d9
Compare
|
@ldez sorry for that question but is there any sample configuration of multiple providers ready, so I can check search and implement UI for providers? |
|
Amazing, when can we get a docker image to test? |
There was a problem hiding this comment.
Many thanks for this awesome PR @jkuri .
After review with @jbdoumenjou :
LGMT 👏 👏 🎉
|
Does the merge finally clear path for 1.6.0? |
|
@kachkaev it's in 1.6 😸 |
First of all, sorry for making PR this huge, I did read the contributing guide but in that case I believe small PR is not possible.
Hi guys, I really like the project and I decided to help you with transition to latest version of Angular rather than using first version.
I also updated UI and started to working on be a slightly more modern but didn't finish things already. First, I would like to know if you guys are even interested of upgrading and improving user interface?
If so, this PR is not finished yet, its a work in progress, but can be done in a day.
I have question if there is a reason why you are sending xhr requests to server in time interval (3000ms)? I believe this is a more or less anti-pattern and should be done with websockets.
All live data on Web UI should transfer data through websockets and if someone is interested of creating server I can update the frontend accordingly.
TODO:
Cheers, Jan