-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traefik always uses hardcoded "traefik" realm for digest authentication. #3837
Comments
I'm not sure how traefik is supposed to handle the realm defined in the Auth.Digest.Users field. how does it work if multiple users have different realm ? maybe a new label is needed ? note: I was looking for this not for digest auth but for basic auth, if it's independant let me know and i'll open another issue |
I'll close this (fixed) issue. |
@geraldcroes this issue is for digest, my PR is for basic only. Do you want a similar PR for digest ? |
Thanks for helping @tcoupin ! Actually we already have a PR in progress for Digest, so it's not necessary. I might leave the issue open since it's not per se fixed ... I'll give it additional thoughts. |
Hey, @geraldcroes any updates on the PR for this issue? Seems weird that this issue is closed, despite the fact that the basic auth realm was fixed in #3917 and not the digest one, which original author concerns about. |
Hi! it has been included for the next version https://github.com/containous/traefik/blob/master/middlewares/auth/digest_auth_test.go#L81 |
Do you want to request a feature or report a bug?
Bug
What did you do?
Ran
And the navigated to http://localhost:8080 in my browser, while watching http requests being passed between the browser and traefik.
What did you expect to see?
I expected to see realm equals "myrealm" in the Www-Authenticate header.
What did you see instead?
I saw realm equals "traefik" in the Www-Authenticate header. See here
Output of
traefik version
: (What version of Traefik are you using?)What is your environment & configuration (arguments, toml, provider, platform, ...)?
No specific configuration.
NewDigestAuthenticator takes realm as the first parameter. Traefik always passes hardcoded "traefik" string
If applicable, please paste the log output in DEBUG level (
--logLevel=DEBUG
switch)The text was updated successfully, but these errors were encountered: