Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS task networking with awsvpc networking mode on EC2 exposes wrong ip #4353

Closed
maartenvanderhoef opened this issue Jan 3, 2019 · 3 comments

Comments

@maartenvanderhoef
Copy link
Contributor

maartenvanderhoef commented Jan 3, 2019

Do you want to request a feature or report a bug?

Bug

What did you do?

Start Traefik as an ECS Service with AWSVPC networking enabled on an EC2 cluster.

What did you expect to see?

I expected the Traefik to expose the backend service with the IP of the attached ENI as it should with AWSVPC networking enabled (similar to Fargate)

What did you see instead?

Traefik exposed the service with the IP of the EC2 instance.

Output of traefik version: (What version of Traefik are you using?)

traefik:v1.7.6-alpine

https://github.com/containous/traefik/blob/ddf199566c0966b674e4a9af0902d1ddaad8eceb/old/provider/ecs/ecs.go#L288 The condition is made for Fargate specific, but not covering awsvpc networking in general.

https://docs.aws.amazon.com/sdk-for-go/api/service/ecs/#Task
https://docs.aws.amazon.com/sdk-for-go/api/service/ecs/#Attachment

@maartenvanderhoef
Copy link
Contributor Author

Created a diff, not sure where to PR against now. v1.7...maartenvanderhoef:v1.7

@juliens juliens added priority/P2 need to be fixed in the future area/provider/ecs kind/bug/confirmed a confirmed bug (reproducible). and removed status/0-needs-triage labels Jan 4, 2019
@dduportal
Copy link
Contributor

Hi @maartenvanderhoef , thanks for interest in the Traefik project !

Your contribution is totally welcome. As you figured out, as this is considered as a bug, the target branch is the v1.7.

You are good to open a PR with your fix, to switch on design and review on the proposed implementation.

Thanks a lot!

@tomMoulard
Copy link
Member

As we no longer support Traefik version 1, @tfny closed this issue.

If this issue persists in version 2, feel free to open a new issue. Thanks!

@traefik traefik locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants