Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a provider for ECS in Traefik v2 #4674

Closed
jbdoumenjou opened this issue Mar 27, 2019 · 20 comments
Closed

Add a provider for ECS in Traefik v2 #4674

jbdoumenjou opened this issue Mar 27, 2019 · 20 comments
Labels
area/provider/ecs kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future status/5-frozen-due-to-age
Projects
Milestone

Comments

@jbdoumenjou
Copy link
Member

Do you want to request a feature or report a bug?

Feature

What did you expect to see?

Traefik v1 supports dynamic config generation for and from a ECS cluster, i.e. it has an ECS provider.

Now that the main changes for v2 are out, we can re-add previously supported providers, such as the one for ECS.

The existing providers, such as docker, as well as the code for the ECS provider in v1.7, can be used for inspiration.

@jbdoumenjou jbdoumenjou created this issue from a note in v2 (To do) Mar 27, 2019
@jbdoumenjou jbdoumenjou added kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future area/provider/ecs and removed status/0-needs-triage labels Mar 27, 2019
@m13t
Copy link

m13t commented Sep 17, 2019

It’s a real shame that ECS Support was dropped as part of V2, but some were brought forward. We have quite a lot of V1 instances running which we were looking forward to bringing up to V2.

@SantoDE
Copy link
Collaborator

SantoDE commented Sep 18, 2019

It's not really "dropped", just not done yet. If you like, take a shot ;)

@m13t
Copy link

m13t commented Sep 18, 2019

Okay that’s good to know. I thought given v2 is now released and it didn’t make the cut, it must have been dropped.

@ldez ldez moved this from issues to todo in v2 Sep 26, 2019
@JavierPandu
Copy link

How about using a "resolver" like in nginx?

@ghost
Copy link

ghost commented Dec 28, 2019

@SantoDE can I take a shot? 🎄

@ldez
Copy link
Member

ldez commented Dec 29, 2019

@ysz Traefik is an open source project, so feel free to work on this.

@andrewelkins
Copy link

Has anyone made progress on creating support for ECS in v2?

@alekitto alekitto mentioned this issue Apr 29, 2020
2 tasks
@a6patch
Copy link

a6patch commented Jun 5, 2020

It's not really "dropped", just not done yet. If you like, take a shot ;)

Isn't this sort of a lie? ECS is supported in the 2.x EE version, which means it HAS been done already. While I think that adding features to an open source project and bundling them as paid premium tier is perfectly ok, REMOVING a feature that already existed as you go from version 1.7 to 2.x is a violation of the spirit of open source and the people that freely contributed to getting the feature into V1.7.

Will ECS ever be added to the Community edition of 2.x?

@SantoDE
Copy link
Collaborator

SantoDE commented Jun 5, 2020

not sure what you talking about @a6patch or where you get that information from. EE 2.X does NOT have ECS as a provider. If its listed somewhere, we'll need to correct it as its untrue.

For ECS in Traefik 2.X, there is the PR #6749 which I'm currently testing on ECS :-)

@a6patch
Copy link

a6patch commented Jun 5, 2020

Sorry if I misunderstood. After waiting a number of months after 2.0 for ECS to get added, I had a conversation with a salesperson that very specifically said that that was an EE feature and wasn't available in the non-EE 2.x Traefik. She must have been mistaken.

I did check your site and the current home page for Traefik 2.x clearly say "Services auto-discovery (Kubernetes, Docker Swarm, Red Hat OpenShift, Rancher, Amazon ECS, Key-Value Stores)".....

I'll keep an eye out for that PR...looking forward to moving off 1.7 :)

@KevinGimbel
Copy link

@SantoDE let me know if you need another pair of eyes for testing! I'm very interested in getting 2.x on ECS!

@KevinGimbel
Copy link

@SantoDE Might be worth adding: I can test against our internal test system where we have a bunch of services running, so we could test the PR against a "real" system (if I can get a docker image from the PR)

@alekitto
Copy link
Contributor

alekitto commented Jun 5, 2020

@KevinGimbel If you need a docker image for testing I've created an alpine based image a month ago and pushed it on docker hub (https://hub.docker.com/r/alekitto/traefik-alpine).

@KevinGimbel
Copy link

@alekitto Neat! I'll see when I can give this a go! :)

@SantoDE
Copy link
Collaborator

SantoDE commented Jun 5, 2020

Can you share your results then @KevinGimbel? Probably, tests from a real system would be more "worth / important" already :-) Maybe we can also talk on the Traefik slack ;-)

@KevinGimbel
Copy link

@SantoDE We can talk on the Traefik Slack, I'm there as "Kevin Gimbel" - just hit me up. I'll need to see when I can try it, maybe tonight or tomorrow!

@aravind-jl
Copy link

Found a vulnerability on 1.7 with ECR scan and finally upgraded to 2x, and now I am here! fingers crossed!

@SantoDE
Copy link
Collaborator

SantoDE commented Jul 9, 2020

@aravind-jl WDYM? I can't really follow, but I'd like to.

@jbdoumenjou
Copy link
Member Author

Closed by #6749

v2 automation moved this from todo to Done Jul 21, 2020
@ldez ldez added this to the 2.3 milestone Jul 21, 2020
@anilmaurya
Copy link

I used Traefik v2 on ECS, published blog post about it https://dev.to/anilmaurya/traefik-v2-with-lets-encrypt-on-amazon-s-elastic-container-service-ecs-1h4h

@traefik traefik locked and limited conversation to collaborators Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/provider/ecs kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future status/5-frozen-due-to-age
Projects
No open projects
v2
Done
Development

No branches or pull requests