-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for WebSockets #8
Comments
Hi! |
Cool, yea a middleware seems like the best place to do it. I saw that patch as well. And I'm sure you are also aware of https://github.com/gorilla/websocket. Not sure which might be easier to implement. |
@emilevauge Let me know how it goes. I saw that this was mailgun/oxy based and wondered if it reacted to websockets in the same way. |
Websocket support is what will would make me try this in favor of HAProxy, as a matter of fact this is why I did not try out vulcand. |
If interested, I created a branch with websocket alpha support taken from https://gist.github.com/sheenobu/5aad1b1c07e9ff52eefe: |
+1 |
1 similar comment
+1 |
+1 Would like to propose also support for http/2 and server sent events. |
If the websocket support gets integrated I really have to switch to traefik from vulcand :) |
Nice work @emilevauge, I'll try swapping vulcan out for traefik tonight :) |
Add Sidecar MaxConn support without other functionality changes
One major reason why I haven't been able to play with something like vulcand is the lack of WebSocket support. This may not be high on the priority list. But support for WebSockets would make this much more viable to me as a replacement for my more kudgly HAProxy and nginx reverse proxy setups in Docker.
The text was updated successfully, but these errors were encountered: