Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rancher documentation. #1776

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Update Rancher documentation. #1776

merged 1 commit into from
Jun 21, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 20, 2017

Description

Update Rancher documentation.

  • add metadata service to toml.md
  • fix config name

@ldez
Copy link
Contributor Author

ldez commented Jun 20, 2017

ping @martinbaillie

martinbaillie
martinbaillie approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@martinbaillie martinbaillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilevauge emilevauge requested a review from SantoDE June 21, 2017 08:56
emilevauge
emilevauge approved these changes Jun 21, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldez
LGTM !

juliens
juliens approved these changes Jun 21, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 01bb0a8 into traefik:master Jun 21, 2017
SantoDE
SantoDE reviewed Jun 22, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were too fast for me :D

LGTM! ;-)

@ldez ldez deleted the refactor/rancher-config branch June 22, 2017 12:39
@ldez ldez added this to the 1.4 milestone Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE left review comments

@juliens juliens juliens approved these changes

@martinbaillie martinbaillie martinbaillie approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/rancher kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @martinbaillie @SantoDE @emilevauge