Add healthcheck command #1982
Merged
Add healthcheck command #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
added
area/healthcheck
kind/enhancement
emilevauge
force-pushed
the
add-healthcheck-command
branch
4 times, most recently
from
b5efa4d
to
17346d5
Compare
timoreimann
reviewed
Aug 21, 2017
cmd/traefik/traefik.go
Outdated
| fmt.Printf("Error calling healthcheck: %s\n", err) | ||
| os.Exit(1) | ||
| } | ||
| if resp.Status != "200 OK" { |
There was a problem hiding this comment.
I'd check resp.StatusCode for http.StatusOK.
emilevauge
force-pushed
the
add-healthcheck-command
branch
from
17346d5
to
b346951
Compare
EtienneDufresne
approved these changes
Aug 21, 2017
vdemeester
suggested changes
Aug 21, 2017
cmd/traefik/traefik.go
Outdated
| @@ -26,6 +27,7 @@ import ( | |||
| "github.com/coreos/go-systemd/daemon" | |||
| "github.com/docker/libkv/store" | |||
| "github.com/satori/go.uuid" | |||
| "net/http" | |||
There was a problem hiding this comment.
The import are a little messed-up 😓 😛
emilevauge
force-pushed
the
add-healthcheck-command
branch
2 times, most recently
from
852ff18
to
f99b765
Compare
timoreimann
approved these changes
Aug 21, 2017
ldez
suggested changes
Aug 21, 2017
cmd/traefik/traefik.go
Outdated
| DefaultPointersConfig: traefikPointersConfiguration, | ||
| Run: func() error { | ||
| if traefikConfiguration.Web == nil { | ||
| fmt.Printf("Please enable the web provider to use healtcheck.\n") |
There was a problem hiding this comment.
I was thinking of homogeneity, but meh, I can change this if you want.
cmd/traefik/traefik.go
Outdated
| fmt.Printf("Bad healthcheck status: %s\n", resp.Status) | ||
| os.Exit(1) | ||
| } | ||
| fmt.Printf("OK: %s\n", resp.Request.URL.String()) |
There was a problem hiding this comment.
fmt.Println("OK:", resp.Request.URL) or fmt.Printf("OK: %s\n", resp.Request.URL)
There was a problem hiding this comment.
Not sure to understand, fmt.Printf("OK: %s\n", resp.Request.URL.String()) -> fmt.Printf("OK: %s\n", resp.Request.URL) ? Why ?
docs/basics.md
Outdated
| @@ -514,6 +514,7 @@ List of Træfik available commands with description : | |||
| - `version` : Print version | |||
| - `storeconfig` : Store the static traefik configuration into a Key-value stores. Please refer to the [Store Træfik configuration](/user-guide/kv-config/#store-trfk-configuration) section to get documentation on it. | |||
| - `bug`: The easiest way to submit a pre-filled issue. | |||
| - `healthcheck`: Calls traefik `/ping` to check health | |||
There was a problem hiding this comment.
Add a dot at the end of the sentence.
emilevauge
force-pushed
the
add-healthcheck-command
branch
2 times, most recently
from
5c3e416
to
57dc669
Compare
ldez
added
status/3-needs-merge
bot/need-human-merge
and removed
status/3-needs-merge
labels
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
traefiker
force-pushed
the
add-healthcheck-command
branch
from
57dc669
to
aaa2743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
traefik healthcheckcommand that can be used by Docker with the newHEALTHCHECKinstruction (see containous/traefik-library-image#12).The
webprovider needs to be enabled./cc @EtienneDufresne @vdemeester
Fixes #1560