-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document custom error page restrictions. #2104
Document custom error page restrictions. #2104
Conversation
84274e5
to
ae037f0
Compare
docs/configuration/commons.md
Outdated
@@ -242,6 +242,8 @@ Instead, the query parameter can also be set to some generic error page like so: | |||
Now the `500s.html` error page is returned for the configured code range. | |||
The configured status code ranges are inclusive; that is, in the above example, the `500s.html` page will be returned for status codes `500` through, and including, `599`. | |||
|
|||
Custom error pages are easiest to implement using the file provider or one of the supported K/V stores. For other dynamic providers, the corresponding template file needs to be customized accordingly and referenced in the Traefik configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add one sentence by line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
98cbb3d
to
aa4c929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM see comment below
In fact, all the k/v store use kv provider ex. https://github.com/containous/traefik/blob/master/provider/etcd/etcd.go#L18 type Provider struct {
kv.Provider `mapstructure:",squash"`
} and the kv provider use template https://github.com/containous/traefik/blob/master/provider/kv/kv.go#L149 and there is no status in the template |
aa4c929
to
10f1751
Compare
@juliens thanks for digging into this. I updated the documentation. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 📖 👏
10f1751
to
8284e14
Compare
This encompasses which kinds of providers can embed custom error pages.
8284e14
to
46b1772
Compare
@containous/traefik PTAL.
In particular, someone with sufficient expertise please acknowledge that custom error pages can really be used with the key/value stores we support.
Refs #2035.