Sanitize cookie names. #2216
Merged
Sanitize cookie names. #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/sticky-session
kind/bug/fix
timoreimann
force-pushed
the
sanitize-sticky-cookie-backend-name
branch
from
ea7f3b1
to
4af7e48
Compare
According to RFC 2616 section 2.2 and [1], only a certain subset of characters is permitted in cookie names. Specifically, slashes contained may cause the cookie to not get set by certain browsers. This change makes sure that the backend name embedded in the cookie name is sanitized accordingly. [1] https://stackoverflow.com/a/1969339
traefiker
force-pushed
the
sanitize-sticky-cookie-backend-name
branch
from
4af7e48
to
c63408d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 2616 section 2.2 and this StackOverflow response, only a certain subset of characters is permitted in cookie names. Specifically, slashes contained may cause the cookie to not get set by certain browsers.
This change makes sure that the backend name embedded in the cookie name is sanitized accordingly.