fix concurrent provider config reloads #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/provider
status/1-needs-design-review
and removed
status/0-needs-triage
labels
|
Anyone else wants to have a look 👼 I would go and rebase after the final approve if this is OK. |
|
@marco-jantke could you solve conflicts before? |
mjeri
force-pushed
the
fix-concurrent-provider-config-reloads
branch
from
f6f0b72
to
f6784cb
Compare
|
Yes, sure thing. Rebased. |
ldez
added
contributor/needs-resolve-conflicts
and removed
contributor/needs-resolve-conflicts
labels
|
@marco-jantke could you rebase again? |
|
@marco-jantke Are you here? 😄 |
|
Yes I am, at least kind of.. :D I already tried to rebase, but there are some real merge conflicts now that I have to take care of. Sorry, I am very busy these weeks/months and try to come back to it soonish. |
nmengin
force-pushed
the
fix-concurrent-provider-config-reloads
branch
from
f6784cb
to
2b8e1c1
Compare
mjeri
force-pushed
the
fix-concurrent-provider-config-reloads
branch
2 times, most recently
from
1536d93
to
2fb4084
Compare
This commit fixes problems with concurrent provider reloads in relation with the throttling functionality of the provider reloads. The failure scenario before looked the following way: Given we have a ProvidersThrottleDuration of 2 seconds and two providers configured: Provider A and B. - a configuration update comes in of provider A at second 0. This config gets applied. - a configuration update comes in of provider B at second 1. The config reload gets delayed. - a configuration update comes in of provier A at second 1.5. This config reload gets delayed. - it is second 2.0 and the last config update of provider A gets applied, whereas the config update of provider B is lost.
traefiker
force-pushed
the
fix-concurrent-provider-config-reloads
branch
from
2fb4084
to
08faafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problems with concurrent provider reloads in relation with the throttling functionality of the provider reloads.
The failure scenario before looked the following way:
configured: Provider A and B.
gets applied.
reload gets delayed.
config reload gets delayed.
applied, whereas the config update of provider B is lost.
This PR fixes this problem by applying the config reload throttling individually for each provider.
Note: As I removed the last usage of concurrent-map with this PR, I also removed the dependency in glide and the vendor directory.