Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the k8s docs example deployment yaml #2308

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Fix the k8s docs example deployment yaml #2308

merged 1 commit into from
Oct 25, 2017

Conversation

gnur
Copy link
Contributor

@gnur gnur commented Oct 24, 2017

This fixes the namespace in the docs to also be kube-system, just like
the yaml in the examples says.

@gnur gnur requested a review from a team as a code owner October 24, 2017 11:21
timoreimann
timoreimann approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnur 👏

@ldez ldez force-pushed the fixed-k8s-service-namespace-docs branch from 7176f0e to 628415f Compare October 24, 2017 13:01
@gnur gnur requested a review from a team as a code owner October 24, 2017 13:01
@ldez ldez changed the base branch from master to v1.4 October 24, 2017 13:01
@ldez ldez added this to the 1.4 milestone Oct 24, 2017
vdemeester
vdemeester approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@ldez ldez added the kind/enhancement a new or improved feature. label Oct 24, 2017
ldez
ldez approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnur @traefiker
Fix the k8s docs deploy yaml
10f8ae3 
This fixes the namespace in the docs to also be kube-system, just like
the yaml in the examples says.
@traefiker traefiker force-pushed the fixed-k8s-service-namespace-docs branch from 628415f to 10f8ae3 Compare October 25, 2017 14:33
@traefiker traefiker merged commit 1b2cb53 into traefik:v1.4 Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@timoreimann timoreimann timoreimann approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnur @vdemeester @timoreimann @ldez @traefiker