Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support regex redirect by frontend #2570

Merged
merged 2 commits into from
Dec 15, 2017
Merged

Support regex redirect by frontend #2570

merged 2 commits into from
Dec 15, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 14, 2017

What does this PR do?

Allow Traefik to make redirect based on config fields from frontends with more liberty to make redirections from (sub)domain A to (sub)domain B and specify any custom redirection rules that will not affect all of the rest of the entrypoint frontends definitions

Motivation

Don't breaking after the final release.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Fixes #1380
Closes #2495
Related to #2133 #572

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Dec 14, 2017
@ldez ldez requested review from a team as code owners December 14, 2017 21:39
@traefiker traefiker added this to the 1.5 milestone Dec 14, 2017
@ldez ldez force-pushed the refactor/redirect-type branch 4 times, most recently from b5c8c57 to 523e408 Compare December 14, 2017 22:33
@ldez ldez changed the title Redirect type Support regex redirect by frontend Dec 14, 2017
@ldez ldez mentioned this pull request Dec 14, 2017
Closed
nmengin
nmengin approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

juliens
juliens approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7ecd6d2 into traefik:v1.5 Dec 15, 2017
@traefiker traefiker mentioned this pull request Dec 15, 2017
Closed
@ldez ldez deleted the refactor/redirect-type branch December 15, 2017 14:55
@ldez ldez mentioned this pull request Dec 21, 2017
Merged
@dimrozakis
Copy link

@ldez Is there any way to force a 301 redirection instead of a 302 using regex redirects, in particular when configuring them via docker labels?

@ldez
Copy link
Contributor Author

ldez commented Jan 6, 2018

@dimrozakis Currently, there is no way to do that even the the file backend provider.

@dimrozakis
Copy link

Ok thanks @idez. I'll open a feature request issue for it.

@dimrozakis dimrozakis mentioned this pull request Jan 6, 2018
Closed
@ldez ldez mentioned this pull request Jan 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/provider/docker area/provider/k8s/ingress area/provider/rancher kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @dimrozakis @juliens @mmatur @nmengin @traefiker