Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all available labels to Rancher Backend #2601

Merged
merged 9 commits into from Jan 3, 2018
Merged

Add all available labels to Rancher Backend #2601

merged 9 commits into from Jan 3, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 20, 2017 •
edited

What does this PR do?

  • add all available labels
    • add passTLSCert label.
    • add HealthCheck labels.
    • add Headers labels.
    • add error pages labels.
    • add rate limit labels.
    • add whitelistSourceRange label.
  • enhance template readability
  • enhance template method readability

Motivation

Homogenization of the providers [part2]: all providers must have the same options available.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Several PRs will come after that for each provider.

Fixes #2557
Related to #618, #1465

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Dec 20, 2017
@ldez ldez added this to the 1.6 milestone Dec 20, 2017
@ldez ldez requested a review from a team as a code owner December 20, 2017 15:39
@ldez ldez force-pushed the refactor/label-rancher branch 3 times, most recently from 86ced61 to 6f11cc7 Compare December 20, 2017 19:50
@ldez ldez mentioned this pull request Dec 20, 2017
Closed
nmengin
nmengin approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@rayout
Copy link

rayout commented Dec 25, 2017

LGTM

1 similar comment
@vinterskogen
Copy link

LGTM

mmatur
mmatur approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@ldez ldez force-pushed the refactor/label-rancher branch 3 times, most recently from 02d5231 to f8f07d0 Compare December 31, 2017 21:58
juliens
juliens approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7e5c258 into traefik:master Jan 3, 2018
@ldez ldez deleted the refactor/label-rancher branch January 3, 2018 22:33
@ldez ldez mentioned this pull request Jan 30, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/provider/rancher kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ldez @rayout @vinterskogen @juliens @mmatur @nmengin @traefiker