Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenge HTTP must ignore deprecated web.path option #2719

Merged
merged 1 commit into from Jan 17, 2018
Merged

Challenge HTTP must ignore deprecated web.path option #2719

merged 1 commit into from Jan 17, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 17, 2018

What does this PR do?

Ignore web.path when used with ACME HTTP-01 Challenge

Motivation

Fix a bug in ACME HTTP-01 Challenge

More

  • Added/updated tests

@traefiker traefiker added this to the 1.5 milestone Jan 17, 2018
ldez
ldez approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ced5aa5 into traefik:v1.5 Jan 17, 2018
@juliens juliens deleted the challenge-http-web-path branch January 25, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @mmatur @ldez @emilevauge @traefiker