Upgrade AWS SKD to version v1.13.1 #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
added
kind/enhancement
ldez
suggested changes
Feb 21, 2018
| @@ -740,7 +742,7 @@ | |||
| [[projects]] | |||
| name = "github.com/jmespath/go-jmespath" | |||
| packages = ["."] | |||
| revision = "bd40a432e4c76585ef6b72d3fd96fb9b6dc7b68d" | |||
| revision = "0b12d6b5" | |||
There was a problem hiding this comment.
I think that it's come from here https://github.com/aws/aws-sdk-go/blob/22de44e02e1bc81533f39df20dce75d5ddb446dd/Gopkg.lock#L13
provider/ecs/ecs.go
Outdated
| @@ -219,8 +222,8 @@ func (p *Provider) listInstances(ctx context.Context, client *awsClient) ([]ecsI | |||
| break | |||
| } | |||
| } | |||
| for _, carns := range clustersArn { | |||
| clusters = append(clusters, *carns) | |||
| for _, cArns := range clustersArn { | |||
traefiker
force-pushed
the
feature/aws-upgrade
branch
from
2b600c2
to
81701da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrade AWS SDK to version v1.13.1
Motivation
Have last bug fixes of the SDK