Add traefik prefix to k8s annotations #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @zifeo both forms are supported😃 |
yue9944882
reviewed
Jul 27, 2018
| - `ingress.kubernetes.io/auth-type: "basic"` | ||
| - `ingress.kubernetes.io/auth-secret: "mysecret"` | ||
| - `traefik.ingress.kubernetes.io/auth-type: "basic"` | ||
| - `traefik.ingress.kubernetes.io/auth-secret: "mysecret"` |
timoreimann
reviewed
Jul 27, 2018
There was a problem hiding this comment.
If we have an inconsistent usage across the examples (can't check right now), we can use this PR to get things straight. But as @yue9944882 explained, the semantics don't change regardless of whether the prefix is attached or not.
|
@yue9944882 I believed so, however I was able to make it work without them in a RBAC cluster. |
|
@zifeo sry i didn't follow. is it related with RBAC? |
|
@yue9944882 Not sure, but I definitely lost 1+ hour trying to having it work. The prefix were the issue in my case. |
|
@zifeo Can you rebase this off of |
|
@dtomcej Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Documentation: fix missing traefik prefix in k8s authentification annotations.
Motivation
—
More
Additional Notes
Likely to have other occurences. I can update this PR to change all of them.
However I need to be clear which annotations requires
traefikin front of them beforehand.