Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about TLS-ALPN challenge. #4106

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Add a note about TLS-ALPN challenge. #4106

merged 1 commit into from
Oct 25, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 25, 2018

What does this PR do?

Add a note about TLS-ALPN challenge.

Motivation

To have a good documentation.

More

  • [-] Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 1.7 milestone Oct 25, 2018
juliens
juliens approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 8c2e994 into traefik:v1.7 Oct 25, 2018
@ldez ldez deleted the feature/acme-tls-note branch October 25, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @jbdoumenjou @dtomcej @traefiker