Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marathon groups subdomain #426

Merged
merged 2 commits into from
Jun 3, 2016
Merged

Conversation

emilevauge
Copy link
Member

@emilevauge emilevauge commented May 31, 2016

Fix marathon groups subdomain management.

Added new optional groupsAsSubDomains:

# Convert Marathon groups to subdomains
# Default behavior: /foo/bar/myapp => foo-bar-myapp.{defaultDomain}
# with groupsAsSubDomains enabled: /foo/bar/myapp => myapp.bar.foo.{defaultDomain}
#
# Optional
# Default: false
#
# groupsAsSubDomains = true

If enabled, instead of:
/foo/bar/myapp => foo-bar-myapp.{defaultDomain}
we now have:
/foo/bar/myapp => myapp.bar.foo.{defaultDomain}

Fixes #169

Signed-off-by: Emile Vauge emile@vauge.com

@emilevauge emilevauge changed the title Add marathon groups subdomain Fix marathon groups subdomain May 31, 2016
@emilevauge emilevauge force-pushed the fix-marathon-directory-subdomain branch from 122859e to d475a56 Compare June 1, 2016 14:47
@vdemeester
Copy link
Contributor

LGTM 🐸

@kbroughton
Copy link

lgtm

Basic *MarathonBasic
TLS *tls.Config
marathonClient marathon.Marathon
BaseProvider `mapstructure:",squash" description:"go through"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The StructTag is useless ...
I think I forgot to remove this one...
@emilevauge : Can you delete it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed ;)

Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
@emilevauge emilevauge force-pushed the fix-marathon-directory-subdomain branch from 302fe48 to 92ca220 Compare June 3, 2016 07:11
@emilevauge emilevauge merged commit c5ac563 into master Jun 3, 2016
@emilevauge emilevauge deleted the fix-marathon-directory-subdomain branch June 24, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants