Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Happy 2019 #4367

Merged
merged 2 commits into from Jan 8, 2019
Merged

Happy 2019 #4367

merged 2 commits into from Jan 8, 2019

Conversation

emilevauge
Copy link
Member

What does this PR do?

s/2018/2019

Motivation

Time is flying

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 1.7 milestone Jan 8, 2019
ldez
ldez approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 📖

juliens
juliens approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ca60c52 into v1.7 Jan 8, 2019
@emilevauge emilevauge deleted the emilevauge-happy-2019 branch January 8, 2019 15:59
@ldez ldez mentioned this pull request Jan 30, 2019
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilevauge @juliens @dduportal @ldez @traefiker