Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Structor to v1.4.0 #4508

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Update Structor to v1.4.0 #4508

merged 1 commit into from
Feb 20, 2019

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Feb 20, 2019 •
edited

Signed-off-by: Damien DUPORTAL damien.duportal@gmail.com

What does this PR do?

This PR changes the behavior for getting structor for generating versioned documentation in Travis:

  • Using godownloader script, added in latest release of structor
  • Fix the structor version, instead of getting "latest" release all the time, to have a constant behavior.
  • Update structor version from 1.3.2 to 1.4.0

Motivation

  • Better automation and release management
  • Constant behavior of builds for future releases
  • Get latest structor changes

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

馃憢

@dduportal
use godownloader for getting structor in Travis
f936ae4 
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@traefiker traefiker added this to the 1.7 milestone Feb 20, 2019
@dduportal dduportal self-assigned this Feb 20, 2019
@dduportal dduportal requested a review from ldez February 20, 2019 10:21
@ldez ldez changed the title use godownloader for getting structor in Travis Update Structor to v1.4.0 Feb 20, 2019
ldez
ldez approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge and removed status/2-needs-review labels Feb 20, 2019
@traefiker traefiker merged commit b48ea1e into traefik:v1.7 Feb 20, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Feb 20, 2019
@dduportal dduportal deleted the go-downloader-structor branch February 20, 2019 14:14
@ldez ldez mentioned this pull request Feb 21, 2019
Merged
2 tasks
@ldez ldez changed the title Update Structor to v1.4.0 Update Structor to v1.4.0 Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/infrastructure kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dduportal @ldez @traefiker