Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full ACME+CRD example #4652

Merged
merged 7 commits into from Mar 27, 2019
Merged

Full ACME+CRD example #4652

merged 7 commits into from Mar 27, 2019

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Mar 22, 2019

What does this PR do?

This PR adds a documentation page for a working configuration example of Traefik with Kubernetes through the IngressRoute CRD, and TLS with Let's Encrypt.

Motivation

It will help people get started with Traefik and Kubernetes. Also we wanted to be absolutely sure that TLS with Let's Encrypt works with the kubernetes CRD provider.

More

- [ ] Added/updated tests

  • Added/updated documentation

Additional Notes

Co-authored-by: Jean-Baptiste Doumenjou jb.doumenjou@gmail.com

@ldez ldez changed the title doc: full ACME+CRD getting started example Full ACME+CRD getting started example Mar 22, 2019
@ldez ldez changed the title Full ACME+CRD getting started example Full ACME+CRD example Mar 22, 2019
@ldez ldez added this to In review in v2 Mar 22, 2019
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👼 Thanks!

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 0779c6a into traefik:v2.0 Mar 27, 2019
v2 automation moved this from To review to Done Mar 27, 2019
@mpl mpl deleted the acmecrd branch May 17, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants