New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full ACME+CRD example #4652
Merged
Merged
Full ACME+CRD example #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantoDE
reviewed
Mar 22, 2019
ldez
added
status/2-needs-review
area/provider/k8s/crd
and removed
status/0-needs-triage
labels
Mar 22, 2019
ldez
changed the title
doc: full ACME+CRD getting started example
Full ACME+CRD getting started example
Mar 22, 2019
SantoDE
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👼 Thanks!
jbdoumenjou
requested changes
Mar 22, 2019
jbdoumenjou
approved these changes
Mar 22, 2019
dtomcej
suggested changes
Mar 22, 2019
ldez
added
kind/enhancement
a new or improved feature.
and removed
area/provider/rancher
contributor/waiting-for-corrections
labels
Mar 22, 2019
dtomcej
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/acme
area/documentation
area/provider/k8s/crd
area/provider/k8s
kind/enhancement
a new or improved feature.
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a documentation page for a working configuration example of Traefik with Kubernetes through the IngressRoute CRD, and TLS with Let's Encrypt.
Motivation
It will help people get started with Traefik and Kubernetes. Also we wanted to be absolutely sure that TLS with Let's Encrypt works with the kubernetes CRD provider.
More
- [ ] Added/updated testsAdditional Notes
Co-authored-by: Jean-Baptiste Doumenjou jb.doumenjou@gmail.com