Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update lego. #4800

Merged
merged 1 commit into from Apr 23, 2019
Merged

fix: update lego. #4800

merged 1 commit into from Apr 23, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 19, 2019 •
edited

What does this PR do?

  • cloudns: fix TTL and status validation
  • sakuracloud: supports concurrent update
  • Disable authz when solve fail.
  • gcloud: use public DNS zones

Fixes #4772

Motivation

Fix some bugs.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added status/2-needs-review area/acme kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Apr 19, 2019
@traefiker traefiker added this to the 1.7 milestone Apr 19, 2019
juliens
juliens approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a6d86cd into traefik:v1.7 Apr 23, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Apr 23, 2019
@traefiker traefiker mentioned this pull request Apr 23, 2019
Closed
2 tasks
@ldez ldez deleted the fix/update-lego branch April 23, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldez @juliens @traefiker