Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth middlewares in kubernetes CRD use secrets #5299

Merged
merged 12 commits into from
Sep 5, 2019
Merged

Auth middlewares in kubernetes CRD use secrets #5299

merged 12 commits into from
Sep 5, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 4, 2019 •
edited by mpl
Loading

What does this PR do?

Use secret in auth middleware in Kubernetes CRD.

Motivation

More security when using auth middleware in Kubernetes CRD

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Sep 4, 2019
@ldez ldez changed the title Auths middleware in kubernetes CRD uses secrets Auth middlewares in kubernetes CRD uses secrets Sep 4, 2019
ldez
ldez approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl
mpl requested changes Sep 5, 2019
View reviewed changes
docs/content/middlewares/digestauth.md Outdated Show resolved Hide resolved
docs/content/middlewares/basicauth.md Outdated Show resolved Hide resolved
docs/content/middlewares/basicauth.md Outdated Show resolved Hide resolved
docs/content/middlewares/digestauth.md Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/server/router/tcp/router.go Outdated Show resolved Hide resolved
@ldez ldez added this to To review in v2 via automation Sep 5, 2019
@traefiker traefiker merged commit 1959e1f into traefik:v2.0 Sep 5, 2019
v2 automation moved this from To review to Done Sep 5, 2019
@ldez ldez deleted the auth-middleware-k8s branch September 5, 2019 11:44
@ldez ldez changed the title Auth middlewares in kubernetes CRD uses secrets Auth middlewares in kubernetes CRD use secrets Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/authentication area/middleware area/provider/k8s/crd area/provider/k8s kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @mpl @jbdoumenjou @ldez @traefiker