New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider default cert domain in certificate store #5353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice catch 👌
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This allows for the default certificate to be considered when getting all domains from a TLS certificate store.
Motivation
When getting all domains for a store, the default cert domain should be included in the domains list. This is applicable when generating ACME domains, it should not generate a certificate for a domain that falls under the default domain.
More
Additional Notes
Co-authored-by: Nicolas Mengin nmengin.pro@gmail.com