Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acme storage file docker mounting example #5633

Merged
merged 1 commit into from Oct 11, 2019

Conversation

jansauer
Copy link
Contributor

It is not possible to mount a relative file. A mount path has to be be absolute.

docker: Error response from daemon: invalid volume specification: '/my/host/acme.json:acme.json': invalid mount config for type "bind": invalid mount path: 'acme.json' mount path must be absolute.
See 'docker run --help'.

More

  • Added/updated tests
  • Updated documentation

@ldez
Copy link
Member

ldez commented Oct 11, 2019

Could you rebase you PR on the branch v2.0 or allow us to edit your PR?

Screenshot from 2019-10-11 09-43-32

@jansauer jansauer force-pushed the patch-1 branch 2 times, most recently from cb9de3e to a9f1f20 Compare October 11, 2019 08:11
@jansauer
Copy link
Contributor Author

@ldez Rebasing my commit onto the v2.0 branch looked strange. Hope this is now the desired form.

@jansauer jansauer changed the base branch from master to v2.0 October 11, 2019 08:13
@ldez ldez added this to To review in v2 via automation Oct 11, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It is not possible to mount a relative file. A mount path has to be be absolute.

```
docker: Error response from daemon: invalid volume specification: '/my/host/acme.json:acme.json': invalid mount config for type "bind": invalid mount path: 'acme.json' mount path must be absolute.
See 'docker run --help'.
```
v2 automation moved this from To review to Done Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants