Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about backtick for rule definition. #5714

Merged
merged 4 commits into from Oct 25, 2019
Merged

Add documentation about backtick for rule definition. #5714

merged 4 commits into from Oct 25, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 23, 2019

What does this PR do?

Add documentation about backtick for rule definition.

Motivation

To have a clear documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Oct 23, 2019
@traefiker traefiker added this to the 2.0 milestone Oct 23, 2019
dduportal
dduportal suggested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal for improvement

docs/content/routing/routers/index.md Outdated Show resolved Hide resolved
docs/content/routing/routers/index.md Outdated Show resolved Hide resolved
docs/content/routing/routers/index.md Outdated Show resolved Hide resolved
docs/content/routing/routers/index.md Outdated Show resolved Hide resolved
docs/content/routing/routers/index.md Outdated Show resolved Hide resolved
docs/content/routing/routers/index.md Outdated Show resolved Hide resolved
dduportal
dduportal approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo on the link to make the CI pass: otherwise we're good on this one

docs/content/routing/routers/index.md Outdated Show resolved Hide resolved
jbdoumenjou
jbdoumenjou approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez and others added 4 commits October 25, 2019 15:10
@ldez @traefiker
doc: add documentation about backtick for rule definition.
86347fe
@ldez @dduportal @traefiker
Apply suggestions from code review
4a5601f 
Co-Authored-By: Damien Duportal <damien.duportal@gmail.com>
@ldez @traefiker
doc: link.
f0d54ce
@ldez @dduportal @traefiker
Update docs/content/routing/routers/index.md
00838c5 
Co-Authored-By: Damien Duportal <damien.duportal@gmail.com>
@traefiker traefiker merged commit 355fe61 into traefik:v2.0 Oct 25, 2019
v2 automation moved this from To review to Done Oct 25, 2019
@ldez ldez deleted the fix/backtick branch October 25, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
area/documentation area/rules kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @jbdoumenjou @dduportal @traefiker