Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI: Sync toolbar table state with url query params #5861

Merged
merged 1 commit into from Nov 20, 2019

Conversation

matthieuh
Copy link
Contributor

What does this PR do?

Sync the web ui ToolbarTable component state with the url query parameters.

Motivation

Changing status and searching in a table state wasn't saved in the navigation. So state was lost going to an other route then going back to the previous one.

@ldez ldez added this to To review in v2 via automation Nov 18, 2019
@ldez ldez added this to the 2.1 milestone Nov 18, 2019
@ldez ldez changed the base branch from master to v2.1 November 19, 2019 09:19
@ldez ldez added kind/bug/fix a bug fix and removed kind/enhancement a new or improved feature. bot/no-merge labels Nov 19, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker force-pushed the sync-toolbar-table-state-with-url branch from c4ed0b5 to d54c080 Compare November 20, 2019 17:40
@traefiker traefiker merged commit 2bcc1b7 into traefik:v2.1 Nov 20, 2019
v2 automation moved this from To review to Done Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants