Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the k8s api version in the documentation #6162

Merged
merged 2 commits into from Jan 13, 2020
Merged

Update the k8s api version in the documentation #6162

merged 2 commits into from Jan 13, 2020

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Update the Deployment API version in the documentation.

Motivation

Fixes #6075

More

  • Added/updated tests
  • Added/updated documentation

@jbdoumenjou jbdoumenjou requested a review from a team as a code owner January 13, 2020 13:46
@traefiker traefiker added this to the 1.7 milestone Jan 13, 2020
timoreimann
timoreimann approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dtomcej
dtomcej approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@jbdoumenjou jbdoumenjou changed the title Fix/k8s api version Update the k8s api version in the documentation Jan 13, 2020
ldez
ldez approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e472561 into traefik:v1.7 Jan 13, 2020
@traefiker traefiker mentioned this pull request Jan 13, 2020
Closed
@jbdoumenjou jbdoumenjou deleted the fix/k8s-api-version branch January 13, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress area/provider/k8s kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbdoumenjou @timoreimann @ldez @dtomcej @traefiker