Add http request scheme to logger #6226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
mpl
reviewed
Feb 5, 2020
ldez
added
contributor/waiting-for-feedback
and removed
contributor/waiting-for-corrections
labels
mpl
approved these changes
Feb 11, 2020
juliens
force-pushed
the
log-http-scheme
branch
from
4640f77
to
186b30c
Compare
juliens
added
status/3-needs-merge
and removed
contributor/waiting-for-feedback
status/2-needs-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added to the logger the http request scheme HTTP/HTTPS.
Motivation
Fixes #6130
More
Additional Notes
Got solution from golang/go#28940 (comment).
Need to add test for the https scheme, but could not figure it out. If someone could give me some directions please.