-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics about TLS #6255
Add metrics about TLS #6255
Conversation
e6a6d97
to
c2b88bb
Compare
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks.
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We (the bot) need to be able to modify your PR.
It should be good now. |
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
What does this PR do?
Add metrics about TLS version and TLS cipher used
Motivation
TLS configuration can have a major effect on CPU usage so this allows to see what TLS versions and ciphers are used.
More
Additional Notes