Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics about TLS #6255

Merged
merged 13 commits into from
Mar 5, 2020
Merged

Add metrics about TLS #6255

merged 13 commits into from
Mar 5, 2020

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Jan 30, 2020

What does this PR do?

Add metrics about TLS version and TLS cipher used

Motivation

TLS configuration can have a major effect on CPU usage so this allows to see what TLS versions and ciphers are used.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@sylr sylr force-pushed the tls-metrics branch 4 times, most recently from e6a6d97 to c2b88bb Compare January 31, 2020 10:18
@sylr sylr changed the title Add metrics about TLS WIP: Add metrics about TLS Jan 31, 2020
@sylr sylr changed the title WIP: Add metrics about TLS Add metrics about TLS Jan 31, 2020
@ldez ldez added this to To review in v2 via automation Feb 1, 2020
@sylr
Copy link
Contributor Author

sylr commented Feb 3, 2020

Fullscreen_03_02_2020_11_56

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
pkg/middlewares/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/middlewares/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/middlewares/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/middlewares/metrics/metrics.go Outdated Show resolved Hide resolved
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks.

pkg/middlewares/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/middlewares/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/tls/cipher_test.go Outdated Show resolved Hide resolved
pkg/tls/cipher_test.go Outdated Show resolved Hide resolved
pkg/tls/cipher_test.go Outdated Show resolved Hide resolved
pkg/tls/cipher_test.go Outdated Show resolved Hide resolved
pkg/tls/cipher_test.go Outdated Show resolved Hide resolved
pkg/tls/cipher_test.go Outdated Show resolved Hide resolved
pkg/middlewares/metrics/metrics.go Outdated Show resolved Hide resolved
sylr and others added 4 commits March 5, 2020 11:02
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
@ldez ldez added this to the 2.2 milestone Mar 5, 2020
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Mar 5, 2020
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (the bot) need to be able to modify your PR.

@sylr
Copy link
Contributor Author

sylr commented Mar 5, 2020

It should be good now.

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit ad6bf93 into traefik:master Mar 5, 2020
v2 automation moved this from To review to Done Mar 5, 2020
@sylr sylr deleted the tls-metrics branch July 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants