Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab name #6543

Merged
merged 1 commit into from Mar 21, 2020
Merged

Fix tab name #6543

merged 1 commit into from Mar 21, 2020

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Mar 21, 2020

What does this PR do?

Fix tab name in sample

Motivation

In the current docs for the page

https://docs.traefik.io/https/acme/

expanding examples:

image

there is a mismatch on the tab File (TOML)

More

  • Added/updated tests
  • Added/updated documentation

@ldez
Copy link
Member

ldez commented Mar 21, 2020

Related to #6519

@ldez ldez added this to To review in v2 via automation Mar 21, 2020
@ldez ldez added area/documentation bot/light-review decreases the number of required LGTM from 3 to 1. status/2-needs-review and removed area/acme status/0-needs-triage labels Mar 21, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 198320b into traefik:v2.1 Mar 21, 2020
v2 automation moved this from To review to Done Mar 21, 2020
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Mar 21, 2020
@mavimo mavimo deleted the patch-1 branch March 21, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants