Force http/1.1 for upgrade (Traefik v1) #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
mpl
requested changes
Mar 23, 2020
mpl
requested changes
Mar 23, 2020
mpl
approved these changes
Mar 23, 2020
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
|
Tested and validated. Thanks @juliens 👍 |
gpaul
reviewed
Mar 24, 2020
| server.defaultForwardingRoundTripper = transport | ||
| server.defaultForwardingRoundTripper, err = newSmartRoundTripper(transport) | ||
| if err != nil { | ||
| log.Errorf("Failed to create HTTP transport: %v", err) |
There was a problem hiding this comment.
Is this really an error we can proceed on? That is unrelated to this PR (it has always just swallowed this error) but it seems strange that an HTTP proxy ignores an error in setting up its transport and proceeds without one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR force the use of http1.1 with the backend when the request is a
Connection:UpgradebecauseConnection: Upgradeis not valid for http2.Motivation
Some kubernetes api server refuse http2 during tls-alpn (like k3s) but some other just don't (like kind) and so, SPDY upgrade fails. This PR fixes this behavior.
Fixes #6527
More
- [ ] Added/updated tests- [ ] Added/updated documentation