Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete an unnecessary warning log #6568

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Delete a confusing log when a deprecated apiVersion is used for a Kubernetes Ingress.
How apiVersion is handled depends on the version of Kubernetes and could generate many unnecessary warning logs.

Motivation

Fixes #6536

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbdoumenjou jbdoumenjou changed the title Delete a confusing log Delete an unnecessary warning log Mar 24, 2020
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit f624449 into traefik:master Mar 25, 2020
v2 automation moved this from To review to Done Mar 25, 2020
@ldez ldez modified the milestones: 2.2, next Mar 31, 2020
@jbdoumenjou jbdoumenjou deleted the fix/ingress-log branch March 31, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

Logs filled with ingress api version deprecation warnings
5 participants