Allow multiple secure middlewares to operate independently #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/bug/fix
Closed
|
Moving to needs-review as requested by @rtribotte |
|
Can we get this back ported to 2.2.X? It seems like 2.3.0 is still a bit away and I would really like to get this bug fix to not duplicated my headers 50 times. |
|
This PR was merged in the wrong branch, it was a mistake, we already back ported this PR inside another PR: https://github.com/containous/traefik/pull/7230/commits We will release a v2.2.11 tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Utilizes the secureContextKey to allow different header middlewares to operate independently, without overwriting the next middleware's context key.
Motivation
Fixes #5538
More
Additional Notes
Because
unrolled/secureuses a private secureContextKey type for storage, we cannot retrieve from this project. Testing this drills down to the base secure project, which is already tested in their repo.Therefore integration testing I feel is the best option at this point.