Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS ECS provider #6749

Merged
merged 15 commits into from
Jul 15, 2020
Merged

Add AWS ECS provider #6749

merged 15 commits into from
Jul 15, 2020

Conversation

alekitto
Copy link
Contributor

@alekitto alekitto commented Apr 29, 2020 •
edited

What does this PR do?

Added ECS dynamic provider in v2 (#4674)

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I used the v1 version of ECS provider as a base and adapted it based on v2 docker provider.

@SantoDE SantoDE self-assigned this Jun 3, 2020
@SantoDE SantoDE mentioned this pull request Jun 5, 2020
Closed
@mmatur mmatur force-pushed the master branch 3 times, most recently from 40c352f to 8b30a15 Compare June 15, 2020 09:59
@ldez ldez added this to To review in v2 via automation Jun 17, 2020
@mmatur mmatur added this to the next milestone Jun 17, 2020
SantoDE
SantoDE requested changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one tiny comment - everything else LGTM :)

docs/content/providers/ecs.md Outdated Show resolved Hide resolved
@alekitto
Copy link
Contributor Author

One small thing I noticed yesterday: the AutoDiscoverClusters setting is true by default. I think that should be false by default if the clusters list is not empty.

What do you think about it?

rtribotte
rtribotte approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

juliens
juliens approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

mmatur
mmatur approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 285ded6 into traefik:master Jul 15, 2020
v2 automation moved this from To review to Done Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees

@SantoDE SantoDE

Labels
area/provider/ecs kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@alekitto @juliens @SantoDE @mmatur @rtribotte @jbdoumenjou @ldez @traefiker