Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Client-go to 0.18.2 #6779

Merged
merged 5 commits into from
May 14, 2020
Merged

Upgrade Client-go to 0.18.2 #6779

merged 5 commits into from
May 14, 2020

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented May 7, 2020

What does this PR do?

This PR:

  • Updates client-go and associated libraries to v0.18.2
  • Rebuilds the CRDs to use the new lib version
  • Adds a make tidy target that runs a go mod tidy to make cleaning the go.mod/go.sum files easier

Motivation

Fixes #6778

More

  • Added/updated tests - None needed, dep upgrade
  • Added/updated documentation - None needed, dep upgrade

Additional Notes

Because this is an invasive change, projects that implement Traefik as a library will require updates as well. This should not be a blocker to this upgrade though.

@ldez ldez added this to To review in v2 via automation May 7, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtomcej dtomcej modified the milestones: 2.2, next May 14, 2020
@traefiker traefiker merged commit 5f0b6fd into traefik:master May 14, 2020
v2 automation moved this from To review to Done May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

Client-go 1.18 upgrade
5 participants