Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ingressClass support to ingress provider #6831

Merged
merged 12 commits into from
Jul 15, 2020
Merged

Add new ingressClass support to ingress provider #6831

merged 12 commits into from
Jul 15, 2020

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented May 20, 2020 •
edited by SantoDE

What does this PR do?

This PR:

  • Adds support for the new IngressClass type
  • Adds support for the new ingressClassname field in ingress objects

Motivation

Fixes #6829

Partially works on #6690

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Manuel Zapf manuel@containo.us

@dtomcej dtomcej changed the title add new ingressClass Add new ingressClass support to ingress provider May 20, 2020
@ldez ldez added the kind/enhancement a new or improved feature. label Jun 2, 2020
@ldez ldez added this to To review in v2 via automation Jun 2, 2020
SantoDE
SantoDE reviewed Jul 10, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 usage-questions left so far. it does work on 1.18 with the new IngressClass tough :) And of course on below 1.18 with the old behavior.

pkg/provider/kubernetes/ingress/client_mock_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/client.go Outdated Show resolved Hide resolved
@SantoDE SantoDE force-pushed the issue-6829 branch 5 times, most recently from 9c28cd5 to c9bbfd8 Compare July 14, 2020 15:53
kevinpollet
kevinpollet reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions.

pkg/provider/kubernetes/ingress/client.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/client.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/client.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/client.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/client_mock_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/ingress/kubernetes.go Outdated Show resolved Hide resolved
ldez
ldez approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@ldez ldez added this to the next milestone Jul 15, 2020
@mmatur mmatur force-pushed the issue-6829 branch 15 times, most recently from bc23370 to b9a9c74 Compare July 15, 2020 16:53
@mmatur mmatur force-pushed the issue-6829 branch 2 times, most recently from e4e51aa to ac04c7f Compare July 15, 2020 17:13
mmatur
mmatur approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit cb6ec50 into traefik:master Jul 15, 2020
v2 automation moved this from To review to Done Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet left review comments

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress area/provider/k8s kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

Implement IngressClass support for Kubernetes 1.18
8 participants
@dtomcej @kevinpollet @SantoDE @mmatur @ldez @mpl @jbdoumenjou @traefiker