Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iOS specific icons #6946

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Add iOS specific icons #6946

merged 3 commits into from
Jul 2, 2020

Conversation

marcmognol
Copy link
Contributor

What does this PR do?

Motivation

I would like to have a beautiful icon on my iOS device when I clip Traefik to my homescreen.
Right now, it is very ugly. see #6945

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

This is related to the issue : #6945

@ldez ldez added the kind/enhancement a new or improved feature. label Jun 22, 2020
@ldez ldez added this to To review in v2 via automation Jun 22, 2020
SantoDE
SantoDE approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

rtribotte
rtribotte approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ldez
ldez approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added this to the next milestone Jul 2, 2020
@traefiker traefiker merged commit ed216be into traefik:master Jul 2, 2020
v2 automation moved this from To review to Done Jul 2, 2020
@ldez ldez mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/webui kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marcmognol @SantoDE @ldez @rtribotte @traefiker @Heisenberg74