Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for InsecureSNI when global is not set #7037

Merged
merged 1 commit into from Jul 13, 2020
Merged

Fix default value for InsecureSNI when global is not set #7037

merged 1 commit into from Jul 13, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Jul 13, 2020

What does this PR do?

This PR fixes the global.insecureSNI default value when the global is not set.

Motivation

Changes the default value for insecureSNI.

Additional Notes

related to #7020

ldez
ldez approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez mentioned this pull request Jul 13, 2020
Closed
rtribotte
rtribotte approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SantoDE
SantoDE approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to To review in v2 via automation Jul 13, 2020
@ldez ldez added this to the 2.2 milestone Jul 13, 2020
@traefiker traefiker merged commit 143e9b6 into traefik:v2.2 Jul 13, 2020
v2 automation moved this from To review to Done Jul 13, 2020
@ldez ldez deleted the fix-default-sni branch July 13, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/tls kind/bug/fix a bug fix
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @SantoDE @ldez @rtribotte @traefiker