Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semantic versioning to enable ingress class support #7065

Merged
merged 1 commit into from Jul 21, 2020
Merged

Use semantic versioning to enable ingress class support #7065

merged 1 commit into from Jul 21, 2020

Conversation

kevinpollet
Copy link
Member

@kevinpollet kevinpollet commented Jul 17, 2020 •
edited by ldez

What does this PR do?

Motivation

This PR fixes the parsing of the Kubernetes server version.

Fixes #7061

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Jul 17, 2020
@ldez ldez added this to the 2.3 milestone Jul 17, 2020
ldez
ldez approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtribotte
rtribotte approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jbdoumenjou
jbdoumenjou approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a136c46 into traefik:v2.3 Jul 21, 2020
v2 automation moved this from To review to Done Jul 21, 2020
@traefiker traefiker mentioned this pull request Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress area/provider/k8s kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kevinpollet @jbdoumenjou @ldez @rtribotte @traefiker