Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Minor language improvement in TLS documentation #7206

Merged
merged 2 commits into from
Aug 25, 2020
Merged

doc: Minor language improvement in TLS documentation #7206

merged 2 commits into from
Aug 25, 2020

Conversation

sharmarajdaksh
Copy link
Contributor

@sharmarajdaksh sharmarajdaksh commented Aug 22, 2020 •
edited

What does this PR do?

  • Makes minor language improvements in the TLS documentation page

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.2 milestone Aug 22, 2020
@sharmarajdaksh sharmarajdaksh changed the title Minor language improvement in TLS documentation Docs: Minor language improvement in TLS documentation Aug 22, 2020
@sharmarajdaksh sharmarajdaksh changed the title Docs: Minor language improvement in TLS documentation doc: Minor language improvement in TLS documentation Aug 22, 2020
kevtainer
kevtainer reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@kevtainer kevtainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connections from clients connections

suggest removing the last connections in this line

@ldez ldez added this to To review in v2 via automation Aug 24, 2020
SantoDE
SantoDE requested changes Aug 24, 2020
View reviewed changes
docs/content/https/tls.md Outdated Show resolved Hide resolved
rtribotte
rtribotte approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SantoDE
SantoDE approved these changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

ldez
ldez approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@sharmarajdaksh @traefiker
Minor language improvement in TLS documentation
fdaa238 
What does this PR do?
- Makes minor language improvements in the TLS documentation page
@sharmarajdaksh @traefiker
Update tls.md
f2e3095
@traefiker traefiker merged commit 3e3b723 into traefik:v2.2 Aug 25, 2020
v2 automation moved this from To review to Done Aug 25, 2020
@ldez ldez added the area/tls label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevtainer kevtainer kevtainer left review comments

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/documentation area/tls kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sharmarajdaksh @SantoDE @kevtainer @ldez @rtribotte @traefiker