Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP-per-task: #841

Merged
merged 2 commits into from
Jan 6, 2017
Merged

IP-per-task: #841

merged 2 commits into from
Jan 6, 2017

Conversation

diegooliveira
Copy link
Contributor

@diegooliveira diegooliveira commented Nov 14, 2016

Support IP per task with marathon/mesos.
Adding tests
Update marathon client version

@diegooliveira
Copy link
Contributor Author

Did some rework and rebase in this feature, making a new PR

@diegooliveira
Copy link
Contributor Author

diegooliveira commented Nov 15, 2016

Hi there @errm , any chance that this PR will be merged?

@emilevauge
Copy link
Member

@diegooliveira Sorry for the delay, we are working on the 1.1 release these days, your PR will be reviewed soon :)

@diegooliveira
Copy link
Contributor Author

Thanks @emilevauge, I'm counting on this to be able to use traefik with our setup. Currently we are using a fork of this repository but wish to change to the official binary. If you need any code or design change, please let me know.

Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a rebase

  Support IP per task with marathon/mesos.
  Adding tests
  Update marathon client version
@diegooliveira
Copy link
Contributor Author

@errm @emilevauge rebased

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks a lot @diegooliveira, and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants