Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New build system #9

Merged
merged 3 commits into from Aug 9, 2018
Merged

New build system #9

merged 3 commits into from Aug 9, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 8, 2018

  • add dep
  • replace build.sh by Makefile
  • use multi-stage build

Closes #5

dduportal
dduportal reviewed Aug 9, 2018
View reviewed changes
Dockerfile Outdated
ENTRYPOINT ["/whoami"]
EXPOSE 80
EXPOSE 80
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to nitpick here but as http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 , a new line is required at the end of the file.

dduportal
dduportal reviewed Aug 9, 2018
View reviewed changes
Makefile
@@ -0,0 +1,11 @@

default: build

This comment was marked as resolved.

Sign in to view

dduportal
dduportal approved these changes Aug 9, 2018
View reviewed changes
Copy link

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur merged commit 72d3d9c into master Aug 9, 2018
@mmatur mmatur deleted the feature/new-build branch August 9, 2018 09:05
@ldez ldez added kind/enhancement a new or improved feature. and removed enhancement labels Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@mmatur mmatur mmatur approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ldez @dduportal @mmatur @emilevauge