Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to show today's current events in the upcoming events #2455

Open
k-webdesign opened this issue Oct 23, 2020 · 13 comments
Open

Allow to show today's current events in the upcoming events #2455

k-webdesign opened this issue Oct 23, 2020 · 13 comments
Labels
feature good first issue help wanted Issues and PRs which are looking for volunteers to complete them.

Comments

@k-webdesign
Copy link

When you set the event list format to "all events" you can't see the events that are happening today. I found a workaround to hide each event at 23:59 at the end of the day but it would be much more comfortable if we had an option to include today's event(s) into the "all events" list.

@asaage
Copy link

asaage commented Oct 23, 2020

Todays events should be included in all events.
If you just need today's events go:
image
What exactly are you trying to accomplish?

@k-webdesign
Copy link
Author

I don't want to show just today's events, I want to show all upcoming events including today's. But "today" becomes invisible as soon as it's 00:01 (or even 00:00, I don't know).

@asaage
Copy link

asaage commented Oct 27, 2020

I can't reproduce that in the demo 🤷‍♂️

image

image
image

image

I found a workaround to hide each event at 23:59 at the end of the day

maybe the problem is in your "workaround"?

@fritzmg
Copy link
Contributor

fritzmg commented Oct 27, 2020

I can reproduce the problem locally in Contao 4.9.8.

@fritzmg
Copy link
Contributor

fritzmg commented Oct 27, 2020

I can also reproduce the problem in the Contao Demo.

@fritzmg
Copy link
Contributor

fritzmg commented Oct 27, 2020

The difference between @asaage 's Test and mine is probably the tl_module.cal_noSpan setting (Shortend view). I disabled it, while @asaage probably kept it enabled. If you disable tl_module.cal_noSpan, then the event list showing all upcoming events will not display today's event. If you enable it, then it will display today's event.

@asaage
Copy link

asaage commented Oct 27, 2020

Yes (Shortened view)-disabled seems to cause that unexpected behaviour.

@asaage
Copy link

asaage commented Oct 27, 2020

I think this is actually a duplicate of #2448

@fritzmg
Copy link
Contributor

fritzmg commented Oct 27, 2020

Hm, this is a tough one to fix. Technically I would say, that the event showing up when Shortened view is enabled is a bug, since it is not a future event any more.

However I do find it desirable to always list events of the current day. May be this would be another checkbox? 😬 Always show events of current day. But then this would also list events of the current day, which have an end time in the past …

@k-webdesign
Copy link
Author

I also think it's a bug...

In which case have events of the current day an end time in the past? They are current when they're today and end somewhen today.

@aschempp
Copy link
Member

It shouldn't be a checkbox, it's simply another option to "Show today and future events" imho.

@aschempp aschempp added feature good first issue help wanted Issues and PRs which are looking for volunteers to complete them. labels Dec 16, 2020
@Ernestopheles
Copy link

Ernestopheles commented Apr 23, 2021

In my case, the event will be shown on the same day as well, but only before start time. As soon as start time is reached, the event will not be shown any more.
using this module:
Screenshot_20210423_165336

My wish is, this event should be shown until end time

@sietsevandreven
Copy link

I came across this issue again. Unfortunately it hasn't been fixed yet. How I expect it to work is that an event becomes invisible when the end time is passed. If no time is specified, the current day's event should be visible until the day is over. If the end time is passed the event should be visible in the past events setting.

It's a really annoying problem and I hope it can be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Development

No branches or pull requests

6 participants