Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License field in the file metadata results in Google warning #4164

Closed
Anke opened this issue Feb 18, 2022 · 21 comments
Closed

License field in the file metadata results in Google warning #4164

Anke opened this issue Feb 18, 2022 · 21 comments
Labels
Milestone

Comments

@Anke
Copy link

Anke commented Feb 18, 2022

Affected version(s)

4.13

Description

It's the first time I used the meta field "license" entering the name of the copyright holder - and just 48 hours later I get this Google warning:

grafik

Is this a bug or what exactly do I have to enter into the license field?

Regards,
Anke

@fritzmg
Copy link
Contributor

fritzmg commented Feb 18, 2022

According to https://schema.org/license license is supposed to be either an URL or a CreativeWork object.

@contao/developers may be we should enforce URLs in that meta field?

@ausi
Copy link
Member

ausi commented Feb 18, 2022

How about changing the label in

<trans-unit id="MSC.aw_license">
<source>License</source>
</trans-unit>
to “License URL”?

@Anke
Copy link
Author

Anke commented Feb 18, 2022

Well, my problem is, that I couldn't find any documentation/manual. Do I enter the name of the copyright holder here or a URL to the respective license like https://creativecommons.org/licenses/by/4.0/ - or both in combination ...

@Anke
Copy link
Author

Anke commented Feb 18, 2022

How about changing the label in

<trans-unit id="MSC.aw_license">
<source>License</source>
</trans-unit>

to “License URL”?

That sounds easy. In this case I could enter a link to a Contao page containing all copyright/licence information?

@asaage
Copy link

asaage commented Feb 18, 2022

used the meta field "license" entering the name of the copyright holder

Well license is not the same as copyrightHolder.
Maybe it's more flexible to use the copyrightNotice property?

@Anke
Copy link
Author

Anke commented Feb 18, 2022

Plus a respective (optional) output of that copyright notice link in the image template?

@fritzmg
Copy link
Contributor

fritzmg commented Feb 18, 2022

That was once rejected: contao/core-bundle#1297 (comment)

@asaage
Copy link

asaage commented Feb 18, 2022

jepp i remember.
I didnt have a look at 4.13 so i dont know what the new field is intended for and how it is rendered in the template.
Just saying if it is rendered as itemprop=license it's only useful for providing a link to the license.

@fritzmg
Copy link
Contributor

fritzmg commented Feb 18, 2022

I didnt have a look at 4.13 so i dont know what the new field is intended for and how it is rendered in the template.

It's not rendered in the template, it used for the meta data.

@Toflar
Copy link
Member

Toflar commented Feb 18, 2022

Only a URL makes sense. We should ideally

  • adjust the label
  • add a url validation
  • check if we can even use the picker there or not (probably not easily doable in that widget)

@m-vo
Copy link
Member

m-vo commented Feb 18, 2022

In this case I could enter a link to a Contao page containing all copyright/licence information?

If this is a use case we could even think about adding a page type for that and then generate a URL to that page by default. Not sure this is worth doing, though.

@fritzmg
Copy link
Contributor

fritzmg commented Feb 18, 2022

check if we can even use the picker there or not (probably not easily doable in that widget)

It's already a picker :)

@aschempp
Copy link
Member

In this case I could enter a link to a Contao page containing all copyright/licence information?

If this is a use case we could even think about adding a page type for that and then generate a URL to that page by default.

What would that page type do?

@leofeyer leofeyer added this to the 4.13 milestone Feb 18, 2022
@asaage
Copy link

asaage commented Feb 18, 2022

I don't understand #3076 completely.
I certainly think it's nice to have that data attached to the file but:

  • would a license-url wich resides invisible in JSON-LD make any licensor or copyright-holder happy?
  • what's the point without a copyright-holder-field? isn't that the requirement of the various stock-image-providers?

@Anke
Copy link
Author

Anke commented Feb 18, 2022

Whether such a URL points to a Contao page or some external page with licensing information - is this really for us to decide? Or are there standards set by stock-image-providers - or by Google? If so, I guess I don't have much use for this field,
I just didn't know when and how to use it, so I just entered a name. If it has to be a URL then it shouldn't accept text.

Maybe someone could occasionally update the documentation and explain how this field works and what it is good for?

@Toflar
Copy link
Member

Toflar commented Feb 18, 2022

Or are there standards set by stock-image-providers - or by Google?

Yes there are. And that's exactly the purpose of this feature. For example, links to the correct https://creativecommons.org license are handled by Google and your image will appear accordingly if you filter the search results for CC licensed images ;)

@leofeyer leofeyer added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Mar 31, 2022
@leofeyer
Copy link
Member

leofeyer commented May 5, 2022

As discussed in the Contao call, we want to rename the field to "License URL" and validate the input.

@leofeyer leofeyer removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label May 5, 2022
@Toflar
Copy link
Member

Toflar commented May 5, 2022

Implemented in #4617

@Toflar Toflar closed this as completed May 5, 2022
@ThomasJanotta
Copy link

BTW, there's still no mention in the manual...
https://docs.contao.org/manual/de/dateiverwaltung/metadaten/#body-inner

(zzz 10 months later)

@m-vo
Copy link
Member

m-vo commented Oct 12, 2022

(zzz 10 months later)

You know how open source projects work? Feel free to contribute.

@ausi
Copy link
Member

ausi commented Oct 13, 2022

BTW, there's still no mention in the manual...

You can use this link to update the manual: https://github.com/contao/docs/edit/main/docs/manual/file-manager/meta-data.de.md

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

9 participants