Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DC_File should not support excluded fields #4927

Closed
aschempp opened this issue Jul 1, 2022 · 1 comment
Closed

DC_File should not support excluded fields #4927

aschempp opened this issue Jul 1, 2022 · 1 comment
Assignees
@aschempp
Milestone
5.0

Comments

@aschempp
Copy link
Member

aschempp commented Jul 1, 2022

Affected version(s)

5.x

Description

#4709 inverses the default for exclude, which means all tl_settings would become a user-configurable permission. However, that does not really make much sense… should we exclude DC_File from permissions? It would probably mean some hardcoding :see
@aschempp aschempp added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Jul 1, 2022
@aschempp aschempp added this to the 5.0 milestone Jul 1, 2022
@aschempp aschempp self-assigned this Jul 1, 2022
@aschempp aschempp removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Jul 6, 2022
@aschempp
Copy link
Member Author

aschempp commented Jul 6, 2022 •
edited

fixed in #4709 (eb3ec70)

@aschempp aschempp closed this as completed Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aschempp aschempp

Labels
None yet
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
1 participant
@aschempp