New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lightbox to the file tree widget #6394
Comments
@koertho can you explain the use case for changing the image size? |
@aschempp : I cite on of my cutomers in german: "Wie kann man das eingefügte Bild vergrößern, um es anzusehen?" I added an additional option to my possible solution list which may be a better option and was my solution to this problem: open the image in a modal/ lightbox on click. It's easy to implement and needs no additional config. I used the model of the filepicker, not perfect, but enough for my usecase:
|
As discussed in the call, we want to add a default image size in the |
would it be much simpler just to add a lightbox to the image in the back end, maybe the same we already have in files? This way the image can be seen better everywhere without requiring DCA config. |
Wouldn‘t that conflict with the drag and drop functionality in e. g. gallery elements? |
That is a good point. It works, but the mouse curser now showing a click icon, not the drag icon. Maybe we add an icon for the lightbox like the remove button instead of linking the whole image. |
Description
Currently there is no nice way to change the size of the preview images for fileTree widget in the backend. One must override
getPreviewImage
method, which is not completely possible since it calls a private method.I see following solutions:
getFilePreviewPath
to protected to allow proper override ofgetPreviewImage
. Disadvantage: you still need to override the methodI would also offer doing a PR for this change, but I would like to discuss your preferred solution first.
The text was updated successfully, but these errors were encountered: