Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

FTP/SMH should only connect on writing, not reading file operations #1957

Closed
markusmilkereit opened this issue Nov 29, 2011 · 5 comments
Closed
Assignees
Labels
Milestone

Comments

@markusmilkereit
Copy link

Opening FTP connections has some serious overhead and should be done as little as possible. Reading files should always work even without SMH, only writing operations really need an FTP connection.

Just a reminder :)

Related issues: #1968

--- Originally created on May 16th, 2010, at 03:33pm (ID 1957)

@ghost ghost assigned leofeyer Nov 29, 2011
@ghost
Copy link

ghost commented Nov 29, 2011

As we spoke yesterday, I will implement this in the SMHExtended aswell.
We can speed up a page impression using SMH from 3seconds to some milliseconds.

I am yet unsure of how to implement it though.

I will play around a little and provide a diff sometime this week.

--- Originally created by xtra on May 16th, 2010, at 05:28pm

@markusmilkereit
Copy link
Author

Is SMHExtended an extension or a core change? Missed that part yesterday. I think most changes of SMHExtended could easily go into an extension, this change however should be in the core in any case.

--- Originally created on May 16th, 2010, at 06:21pm

@ghost
Copy link

ghost commented Nov 29, 2011

http://www.contao.org/erweiterungsliste/view/smhextended.de.html

It is an extension which is way too big to make it into core.
The current version also still might have bugs and is therefore IMO not yet stable enough to make it into the core anyway.
The next version is btw. already underway with new features like private key auth in addition to only user/pass auth.
Expect it to be released sometime this week.

--- Originally created by xtra on May 16th, 2010, at 06:31pm

@leofeyer
Copy link
Member

Implemented in bfb6119. This is truly a major performance improvement if you are required to use the Safe Mode Hack! Especially in the front end, it drastically reduces the number of FTP connections.

--- Originally created on May 29th, 2010, at 11:58am

@leofeyer
Copy link
Member

--- Originally completed on May 29th, 2010, at 11:58am

@ghost ghost mentioned this issue Nov 29, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants