Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Idea: Switch to another compiler for LESS fiels Less.php, http://lessphp.gpeasy.com/ #7012

Closed
kozi opened this issue May 19, 2014 · 18 comments
Closed
Labels
Milestone

Comments

@kozi
Copy link

kozi commented May 19, 2014

Less.php, http://lessphp.gpeasy.com/
Github: https://github.com/oyejorge/less.php

+ Compiles Bootstrap LESS files

@leofeyer
Copy link
Member

Why should we do this? We are currently using the LESS compiler which is also used in Symfony.

@kozi
Copy link
Author

kozi commented May 19, 2014

It compiles the current bootstrap version.

@andreasisaak
Copy link

What is bootstrap?

@kozi
Copy link
Author

kozi commented May 19, 2014

@tristanlins
Copy link
Contributor

I don't like the idea to switch to another compiler, only because it can compile the bootstrap css framework. If we decide to go this way, we will never end to switch the compiler, because no php compiler seems to be full less.js compatible.

The only acceptable solutions I see is to make the less compiler plugable/switchable.

@leofeyer
Copy link
Member

The only acceptable solutions I see is to make the less compiler plugable/switchable.

Are the Assetic libraries available through the DI container in Symfony?

@aschempp
Copy link
Member

You will obviously need the AsseticBundle for that
https://github.com/symfony/AsseticBundle

Components are "hooked" into the DI using bundles in Symfony.

Sorry: to answer your question: yes

@leofeyer
Copy link
Member

Sure? Do they really make the vendor libraries available as a service? Or do they just make Assetic available via DIC?

@aschempp
Copy link
Member

I'm not sure what you mean. If a class is available in the DIC, it's called a service. So I read your questions as "is it true or true?" :D

@aschempp
Copy link
Member

Ah, now I got your question. Checking...

@aschempp
Copy link
Member

As far as I understand the docs (I do not have any experience, I think @tristanlins has), AsseticBundle does not provide a service, but it makes the class/factory configurable to handle any file with any compiler (which is what this ticket requests).

@leofeyer
Copy link
Member

leofeyer commented Jun 1, 2014

Ok, then please wait for the Contao with Symfony version (expected in May, 2015) and adjust the Assetic bundle as mentioned by @aschempp.

@leofeyer leofeyer closed this as completed Jun 1, 2014
@dominikzogg
Copy link
Contributor

@leofeyer https://github.com/oyejorge/less.php got a wrapper class, so you can use same code, but the compiler is much better

@Aybee
Copy link
Contributor

Aybee commented Oct 17, 2014

Starting with this issue on leafo
leafo/lessphp#520
I came up to this post
leafo/lessphp#535 (comment)
Here leafo recommends to use oyejorge instead of leafo as leafo is no longer supported.
I tested oyejorge in Contao 3.3.5 and it works without error.

Maybe its easy to switch to oyejorge in next maintenance release.
https://github.com/leafo/lessphp
https://github.com/oyejorge/less.php

@leofeyer
Copy link
Member

We'll switch if they do: kriswallsmith/assetic#557

@leofeyer leofeyer reopened this Oct 21, 2014
@dominikzogg
Copy link
Contributor

@leofeyer its not a requirement of assetic, so you can change it anytime, with the same filter

@psi-4ward
Copy link
Contributor

TL_ROOT$ php composer/composer.phar remove leafo/lessphp
TL_ROOT$ cd composer
TL_ROOT/composer$ php composer.phar require oyejorge/less.php

@leofeyer leofeyer added this to the 3.5.0 milestone Nov 7, 2014
@leofeyer leofeyer added defect and removed feature labels Nov 18, 2014
@leofeyer leofeyer modified the milestones: 3.4.0, 3.5.0 Nov 18, 2014
@leofeyer
Copy link
Member

Contao 3.4 will be using oyejorge/less.php then (see bf2110e).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants