Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Edit image-size in content element via lightbox #5390

Closed
ngdot opened this issue Jun 21, 2016 · 6 comments · Fixed by #5610
Closed

Feature: Edit image-size in content element via lightbox #5390

ngdot opened this issue Jun 21, 2016 · 6 comments · Fixed by #5610
Labels
feature

Comments

@ngdot
Copy link

ngdot commented Jun 21, 2016 •
edited

It would be nice if we can edit the predefined image-sizes via lightbox from a content element. So we dont have to switch for a quick change.
artikel iso 9001 inhaltselement id 2092 bearbeiten contao open source cms 3 5

Maybe a small icon, after the select fields.
@ngdot ngdot changed the title Feature: Edit image-size in content element Feature: Edit image-size in content element via lightbox Jun 21, 2016
@leofeyer
Copy link
Member

Although I like the idea, it is not trivial to implement. We need the ID of the theme to know which image sizes to show and we do not have this in the article module (or news module or …).

@leofeyer leofeyer reopened this Jan 20, 2017
@leofeyer leofeyer added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Jan 20, 2017
@ngdot
Copy link
Author

ngdot commented Jan 20, 2017

Es würde meiner Meinung nach auch reichen, wenn sich auf Klick des neuen Icons einfach die Bildgrößen in der Lightbox öffnen. So spare ich immer noch ein paar Klicks.

@fritzmg
Copy link
Contributor

fritzmg commented Jan 20, 2017

What about just editing the currently selected image size? Similar to the ContentModule element.

@aschempp
Copy link
Member

aschempp commented Jan 20, 2017 via email

@asaage
Copy link

asaage commented Jan 20, 2017 •
edited

the image size ID is not related to a theme

honestly: i think this is a bug because you define them by theme.

@leofeyer
Copy link
Member

Should be fairly simple, the image size ID is not related to a theme. Dunno about access permission though.

This would only work if an image size has been selected and saved already. But I agree that this is the most feasible solution.

@leofeyer leofeyer removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label May 15, 2017
@leofeyer leofeyer transferred this issue from contao/core Oct 17, 2022
@aschempp aschempp mentioned this issue Dec 26, 2022
Merged
@leofeyer leofeyer closed this as completed Jan 9, 2023
leofeyer added a commit that referenced this issue May 30, 2023
@aschempp @leofeyer
Add a an "edit image size" popup link (see #5610)
05af052 
Description
-----------

Fixes #5390

Commits
-------

f837fa9 Added image size edit popup
9bbae92 Correctly remove the button title if the button is disabled
02c43e8 Merge remote-tracking branch 'upstream/5.x' into feature/edit-image-s…
deaa259 Update the scripts
93d8747 Merge remote-tracking branch 'upstream/5.x' into feature/edit-image-s…
1ee1061 Correctly enable the image size button
9aef364 Fixed the button title not using Contao tips
10ddcca Reset the cursor if a button is disabled

Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer added a commit to contao/core-bundle that referenced this issue May 30, 2023
@aschempp @leofeyer
Add a an "edit image size" popup link (see #5610)
ffd9c17 
Description
-----------

Fixes contao/contao#5390

Commits
-------

f837fa9b Added image size edit popup
9bbae923 Correctly remove the button title if the button is disabled
02c43e8e Merge remote-tracking branch 'upstream/5.x' into feature/edit-image-s…
deaa259d Update the scripts
93d8747f Merge remote-tracking branch 'upstream/5.x' into feature/edit-image-s…
1ee10611 Correctly enable the image size button
9aef364f Fixed the button title not using Contao tips
10ddcca1 Reset the cursor if a button is disabled

Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an "edit image size" popup link aschempp/contao
5 participants
@aschempp @leofeyer @asaage @fritzmg @ngdot